I encountered this today and thought I’d share as I thought I understood brackets and mathematical precedents but apparently I don’t.
If Not i = 0 Then // This line of code is bad
The first line evaluates apparently to (not i) = 0. And (not i) is false for anything other than 0
Thus the below code fails:
[code]// This doesn’t work
// This DOES work
Not the expected answer, but what about:
If i <> 0 Then
you compare 2 values with the = operator
Nothing wrong with that code. Try this:
Dim i As Integer = 2
i = Not i
print i.totext
which will give you -3.
[quote=341438:@Ulrich Bogun]Nothing wrong with that code. Try this:
Dim i As Integer = 2
i = Not i
print i.totext
which will give you -3.
Not sure what your point is, Ulrich. Your example agrees with Jean-Ives who said “you compare 2 values with the = operator”
I think his point is that he’s showing a Bitwise NOT vs Logical negation
IMHO this is also bad:
If Not (i = 0) Then
and should be
If i <> 0 Then
as its so much easier to read.
http://developer.xojo.com/not-equals
I agree that
If i <> 0 Thenis generally easier to read.
In my case, I had a multi part if that felt better with a not
If not SomeMethod and not level = 0 thenWhich should actually have been
If not SomeMethod and not (level = 0) then
Yup, that is a pretty good use.
Making a statement into a readable sentence is always good for readability
TomE
July 21, 2017, 1:54pm
9
bah. Readable code… Just do some Perl for fun
for (my $i = @pids; $i>=0; $i--) {
if ($pids[$i] =~ /^someprocess/) {
$pids[$i] =~ /^\\S+\\s+(\\d+).+/;
$pids[$i] = $1;
next;
}
}
Oh well, It´s friday and urgent need for the weekend
I always try to avoid NOT as negations make code harder to understand, eg
If loaded = false
Instead of
If NOT loaded = true
The negation requires some mental arithmetic that can be a cause of annoying bugs when you start combining them.
Norman_P
July 21, 2017, 2:24pm
11
[quote=341466:@Markus Winter]I always try to avoid NOT as negations make code harder to understand, eg
If loaded = false
Instead of
If NOT loaded = true
The negation requires some mental arithmetic that can be a cause of annoying bugs when you start combining them.[/quote]
[code]if not loaded then
if not firstRun then
etc[/code]
I would write
If (not SomeMethod) and (not (level = 0)) thenI always put ( ) because I’m afraid of
If not SomeMethod and not (level = 0) thenbe interpreted as
If not (SomeMethod and not (level = 0)) then
