Code review - please :)

General
1

Hi,
Could someone please tell me why the database file gets saved perfectly, BUT, the “File could not be created” error message still displays (even though there is obviously no error)??

[code] Dim source As FolderItem = SpecialFolder.ApplicationData.Child(“Snippets Data”).Child(“Snippets.db”)

If source <> Nil Then

Dim dlg as New SaveAsDialog
Dim f as FolderItem
dlg.InitialDirectory = SpecialFolder.Desktop
dlg.promptText = "File Details"
dlg.SuggestedFileName = "Snippets Database.db"
dlg.Title = "Export Snippets Database"
dlg.Filter = FileTypes1.SQLite
f = dlg.ShowModal()

if f <> Nil then
  If f.Exists Then f.delete
  source.CopyFileTo f
  ExportWindow.close
  
  
  if f.LastErrorCode <> 0 then
    MsgBox("File could not be created!")
    
  else
    MainWindow.m.DeliverNotification( MainWindow.CreateMessage )
  end if
  
end If

else
MsgBox(“The snippets database seems to no longer exist?”)

end if[/code]

2

So what does f.LastErrorCode actually get set to?

3

Try replacing

if f.LastErrorCode <> 0 then

by

if source.LastErrorCode <> 0 then
4

Michael,
Thanks - that worked, but I have no idea why?

I was advised to check for “LastErrorCode” before displaying the notification - that’s why I included that line of code.
How / where do I check for an error with f before displaying the notification??

Thanks.

5

It works because you are concerned about an error occurring when executing CopyFileTo which is called as a method of source, not f – f is just a parameter identifying the file the contents of source should be copied to.

6

Thanks.