A window is opening when I am not calling for it

General
1

Okay, this is making me nuts! So I have a window that is used to review readings. And I have two buttons set up. One to increment forward and one to decrement backwards through a recordset. BUT everytime I click either button another window ( the one that is used to get the input ) opens, even though I have no code in the button explicitly calling to open the window! This is a new issue and it’s driving me nuts!

This is the code for the NextRecord Button

// Variables defined here..
Var i As Integer = lblRnum.Text.ToInteger // Get the displayed image number for increment...
Var rsCnt As RowSet = dbMeters.SelectSQL( "SELECT * FROM tblReviewReads WHERE statusOf=?", "A" ) // Get the record count... 
Var iRecCnt As Integer = rsCnt.RowCount // Put it into an integer format for use...
Var rsData As RowSet

// The code that does magical things...
i = i + 1 // Increment the record counter +1 this will be used to pull the next record in a query after we test for record positioning...

//Test this value to see if we have reached the end of the recordset...
If( i = iRecCnt ) Then
  Me.Enabled = False
Else
  Me.Enabled = True
End If

// Now we test to see if the value is 2 or more... this will enable the record back button...
If( i = 1 ) Then
  btnPrevious.Enabled = False
ElseIf( i >= 2 ) Then
  btnPrevious.Enabled = True
End If

// Get the next recordset now...
rsData =  dbMeters.SelectSQL( "SELECT * FROM tblReviewReads WHERE rNum=?", i.ToString )
lblRnum.Text = i.ToString // Set the visible element to show the new record number...

// This is a test
If( rsData.Column( "acctNum" ).StringValue.Left( 4 ) = "Tank" ) Then
  'txtAddress.Text = rsData.Column( "address" ).StringValue
  lblMerSerNum.Text = "Tank Ser #"
ElseIf( rsData.Column( "acctNum" ).StringValue.Left( 4 ) <> "Tank" ) Then
  'txtAddress.Text = rsData.Column( "address" ).StringValue
  lblMerSerNum.Text = "Meter Ser #"
Else
  'txtAddress.Text = rsData.Column( "address" ).StringValue
  lblMerSerNum.Text = "Meter Ser #"
End If

txtCurrRead.Text = rsData.Column( "currRead" ).StringValue
txtCustNum.Text = rsData.Column( "acctNum" ).StringValue
txtLastRead.Text = rsData.Column( "lastRead" ).StringValue
txtLastReadDate.Text = rsData.Column( "readDate" ).StringValue
txtMetSerNum.Text = rsData.Column( "unitSerNum" ).StringValue
txtNotes.Text = rsData.Column( "notes" ).StringValue
txtJustHere.SetFocus
frmReadReview.mthSourceTest( )

lblRecCntr.Text = i.ToString + " Of " + iRecCnt.ToString

I don’t understand HOW this would fire a window open command.

2

My guess is something in a TextChanged event is calling an implicit instance window.

Very, very rarely should implicit instance be used. It leads to problems like this.

2 Likes
3

As @Thom_McGrath stated, somewhere the other window is being called

Implicit instance

1 Like
4

I don’t have any TextChanged events defined. All I have are FocusRecieved and FocusLost and they just change the background colors. The only time I call to open or close a window is via a button.

5

Set a breakpoint in the other window’s Open(ing) event and see if you can get a trace on it.

6

Are-you using a Window Property or Method or Function from this Window like:

wReadings.<Property | Method | foo = Function>

Property can be a FolderItem, a String, an Integer, an array, etc.

Using that syntax is what was called Implicit Instance above.

image
image770×692 44 KB

Disable “Implicit Instance” in the Properties pane → ID → Window Behavior as you can see above it is set ON by default.

Then run and watch what happens…

7

I use methods for my actions. I don’t really mess with properties as I am still learning what everything does and how it works. I tend to keep it as simple as I can.

8

You’re probably running into Implicit Instance. Disable it like Emile demonstrated and see what happens.

9

I disabled it and it throws errors… reviewing the errors I was able to find some code I copied for changing background color but didn’t update the form name and viola… problem is resolved. Thanks!

10

Since you’re new to this, I would advise you to get into the habit of coding without implicit instance turned on. Work through your existing errors, and ask us for help with the rest.

Implicit instance is probably the fastest path to unmaintainable spaghetti code.

3 Likes
11

Not necessarily new, just a casual coder that creates to scratch personal itches. I do this in my spare time to keep my mind sharp and to create things I can use that do not exist elsewhere or in the format I want. Thank you though. I did learn something valuable today.

12

Implicit instance strikes again. I swear, I’d love to know the statistics as to how much this feature helps vs how much confusion and frustration it causes. At best it leads to poor coding practices – at worst you have people spending hours puzzling at what is going on.

13

Of course, but the problem is elsewhere.

The problem is where to place Properties, Methods and Functions (to be used everywhere).

I too misunderstand how to use these and where to put them.

Until someone train me / told me how to do that the good way.

I was even lost because my Property (stored into another window) does not holds the value I was awaiting…

Same arise with Static variable declaration until I needed it !

Glad to be helpful.

14

When used right, it helps immensely. Sure, it can bite you in the b*tt, but so can a lot of other things. I’ve got a million lines of code that would have been a lot more complex without it. Implicit instance is very useful for beginners. It’s the intermediates that start to get in trouble.

15

I think are your field assignments ( txtCurrRead.Text = …) that open a window

Use this syntax:

self.txtCurrRead.Text = “bonjour”

16

Things like this frustrate me to no end because the person who decided the switch should be hidden doesn’t spend any time here helping the people they’ve caused problems for.